-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed activation bug with frame switching #1647
Conversation
Pull Request Test Coverage Report for Build 5477
💛 - Coveralls |
@@ -571,7 +571,7 @@ export default class CanvasWrapperComponent extends React.PureComponent<Props> { | |||
canvasInstance.fit(); | |||
} | |||
} | |||
if (activatedState.objectType !== ObjectType.TAG) { | |||
if (activatedState && activatedState.objectType !== ObjectType.TAG) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can we get situation when activatedStateID !== null
, but it isn't contained in annotations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsekachev, have no idea but in some situations we have annotations
with empty list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we should investigate the root cause. It looks like workaround.
At least need to understand the reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsekachev, i guess we can recreate an issue for further investigation and commit this changes to avoid canvas failing. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Nice way. Could you create it?
Motivation and context
This PR fixed #1611
How has this been tested?
Manually
Checklist
develop
branch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changescvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.