Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed activation bug with frame switching #1647

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Conversation

ActiveChooN
Copy link
Contributor

Motivation and context

This PR fixed #1611

How has this been tested?

Manually

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5477

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.727%

Totals Coverage Status
Change from base Build 5470: 0.0%
Covered Lines: 10904
Relevant Lines: 16185

💛 - Coveralls

@@ -571,7 +571,7 @@ export default class CanvasWrapperComponent extends React.PureComponent<Props> {
canvasInstance.fit();
}
}
if (activatedState.objectType !== ObjectType.TAG) {
if (activatedState && activatedState.objectType !== ObjectType.TAG) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we get situation when activatedStateID !== null, but it isn't contained in annotations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsekachev, have no idea but in some situations we have annotations with empty list

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ActiveChooN

Probably we should investigate the root cause. It looks like workaround.
At least need to understand the reason

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsekachev, i guess we can recreate an issue for further investigation and commit this changes to avoid canvas failing. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ActiveChooN

Yep. Nice way. Could you create it?

@ActiveChooN ActiveChooN merged commit 45f71f8 into develop Jun 5, 2020
@nmanovic nmanovic deleted the dk/batch_of_fixes_1 branch June 6, 2020 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVAT new UI: Error when switching to another frame immediately after opening the job
3 participants